lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Dec 2016 14:45:53 +0100 From: Burak Ok <burak-kernel@...0k.de> To: linux-kernel@...r.kernel.org Cc: linux-scsi@...r.kernel.org, Martin K Petersen <martin.petersen@...cle.com>, James E J Bottomley <jejb@...ux.vnet.ibm.com>, Sesidhar Baddela <sebaddel@...co.com>, Karan Tilak Kumar <kartilak@...co.com>, Narsimhulu Musini <nmusini@...co.com>, linux-kernel@...cs.fau.de, Burak Ok <burak-kernel@...0k.de>, Andreas Schaertl <andreas.schaertl@....de> Subject: [PATCH] snic: Return error code on memory allocation failure If a call to mempool_create_slab_pool() in snic_probe() returns NULL, return -ENOMEM to indicate failure. mempool_creat_slab_pool() only fails if it cannot allocate memory. https://bugzilla.kernel.org/show_bug.cgi?id=189061 Reported-by: bianpan2010@....edu.cn Signed-off-by: Burak Ok <burak-kernel@...0k.de> Signed-off-by: Andreas Schaertl <andreas.schaertl@....de> --- drivers/scsi/snic/snic_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/snic/snic_main.c b/drivers/scsi/snic/snic_main.c index 396b32d..7cf70aa 100644 --- a/drivers/scsi/snic/snic_main.c +++ b/drivers/scsi/snic/snic_main.c @@ -591,6 +591,7 @@ snic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) if (!pool) { SNIC_HOST_ERR(shost, "dflt sgl pool creation failed\n"); + ret = -ENOMEM; goto err_free_res; } @@ -601,6 +602,7 @@ snic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) if (!pool) { SNIC_HOST_ERR(shost, "max sgl pool creation failed\n"); + ret = -ENOMEM; goto err_free_dflt_sgl_pool; } @@ -611,6 +613,7 @@ snic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) if (!pool) { SNIC_HOST_ERR(shost, "snic tmreq info pool creation failed.\n"); + ret = -ENOMEM; goto err_free_max_sgl_pool; } -- 2.7.4
Powered by blists - more mailing lists