| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <f537c425b91cb45de55d6ad7851a4dbd3b2109db.1482241751.git.afonsobordado@az8.co>
Date: Wed, 21 Dec 2016 14:59:58 +0000
From: Afonso Bordado <afonsobordado@....co>
To: gregkh@...uxfoundation.org
Cc: devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: [PATCH v3 3/4] staging: emxx_udc: Remove unecessary temporary variable
This improves code readability.
Signed-off-by: Afonso Bordado <afonsobordado@....co>
---
drivers/staging/emxx_udc/emxx_udc.c | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
index 0963533..45808ed 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -556,21 +556,19 @@ static void _nbu2ss_dma_unmap_single(
static int ep0_out_pio(struct nbu2ss_udc *udc, u8 *pBuf, u32 length)
{
u32 i;
- int nret = 0;
u32 numreads = length / sizeof(u32);
union usb_reg_access *pBuf32 = (union usb_reg_access *)pBuf;
- /*------------------------------------------------------------*/
+ if (!numreads)
+ return 0;
+
/* PIO Read */
- if (numreads) {
- for (i = 0; i < numreads; i++) {
- pBuf32->dw = _nbu2ss_readl(&udc->p_regs->EP0_READ);
- pBuf32++;
- }
- nret = numreads * sizeof(u32);
+ for (i = 0; i < numreads; i++) {
+ pBuf32->dw = _nbu2ss_readl(&udc->p_regs->EP0_READ);
+ pBuf32++;
}
- return nret;
+ return numreads * sizeof(u32);
}
/*-------------------------------------------------------------------------*/
--
2.9.3
Powered by blists - more mailing lists