lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Dec 2016 13:06:47 -0300 From: Arnaldo Carvalho de Melo <acme@...nel.org> To: Joe Stringer <joe@....org> Cc: LKML <linux-kernel@...r.kernel.org>, netdev <netdev@...r.kernel.org>, Wang Nan <wangnan0@...wei.com>, ast@...com, Daniel Borkmann <daniel@...earbox.net> Subject: Re: [PATCH perf/core REBASE 3/5] tools lib bpf: Add bpf_prog_{attach,detach} Em Tue, Dec 20, 2016 at 10:50:22AM -0800, Joe Stringer escreveu: > On 20 December 2016 at 06:32, Arnaldo Carvalho de Melo <acme@...nel.org> wrote: > > Em Tue, Dec 20, 2016 at 11:18:51AM -0300, Arnaldo Carvalho de Melo escreveu: > >> This one makes it fail for CentOS 5 and 6, others may fail as well, > >> still building, investigating... > > > > Ok, fixed it by making it follow the model of the other sys_bpf wrappers > > setting up that bpf_attr union wrt initializing unamed struct members: > > - union bpf_attr attr = { > > - .target_fd = target_fd, > > - }; > > + union bpf_attr attr; > > + > > + bzero(&attr, sizeof(attr)); > > + attr.target_fd = target_fd; > Ah, I just shifted these across originally so the delta would be > minimal but now I know why this code is like this. Thanks. np, making sure this code works in all those environments requires automation, I'd say its impossible otherwise, too many details :-\ Fixed, pushed, merged, should hit 4.10 soon :-) - Arnaldo
Powered by blists - more mailing lists