linux-kernel - Re: [PATCH] sgi-xp: use designated initializers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPp3RGpypuUhOoEMv_wODdD4m4VoRytuRrJhL1NyJYwwqBxCcA@mail.gmail.com>
Date:   Wed, 21 Dec 2016 10:24:14 -0600
From:   Robin Holt <robinmholt@...il.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, Cliff Whickman <cpw@....com>
Subject: Re: [PATCH] sgi-xp: use designated initializers

On Fri, Dec 16, 2016 at 7:01 PM, Kees Cook <keescook@...omium.org> wrote:
> Prepare to mark sensitive kernel structures for randomization by making
> sure they're using designated initializers. These were identified during
> allyesconfig builds of x86, arm, and arm64, with most initializer fixes
> extracted from grsecurity.

I guess I don't understand the context enough here to give you a
Signed-off-by.  Can you give us more background on this randomization?

>From what I see in the code here, I can see you are providing
equivalent functionality and I would give it a signed-off-by, but I am
not sure this randomization of which you speak is not going to cause
problems for XP, XPC, XPNET, and XPMEM (out of tree GPL kernel
module).

Robin