linux-kernel - Re: [RFC PATCH 04/14] sparc64: load shared id into context register 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161221181616.GD3311@ravnborg.org>
Date:   Wed, 21 Dec 2016 19:16:16 +0100
From:   Sam Ravnborg <sam@...nborg.org>
To:     Mike Kravetz <mike.kravetz@...cle.com>
Cc:     sparclinux@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>,
        Bob Picco <bob.picco@...cle.com>,
        Nitin Gupta <nitin.m.gupta@...cle.com>,
        Vijay Kumar <vijay.ac.kumar@...cle.com>,
        Julian Calaby <julian.calaby@...il.com>,
        Adam Buchbinder <adam.buchbinder@...il.com>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Michal Hocko <mhocko@...e.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RFC PATCH 04/14] sparc64: load shared id into context register 1

On Sun, Dec 18, 2016 at 04:22:31PM -0800, Mike Kravetz wrote:
> On 12/16/2016 11:45 PM, Sam Ravnborg wrote:
> > Hi Mike
> > 
> >> diff --git a/arch/sparc/kernel/fpu_traps.S b/arch/sparc/kernel/fpu_traps.S
> >> index 336d275..f85a034 100644
> >> --- a/arch/sparc/kernel/fpu_traps.S
> >> +++ b/arch/sparc/kernel/fpu_traps.S
> >> @@ -73,6 +73,16 @@ do_fpdis:
> >>  	ldxa		[%g3] ASI_MMU, %g5
> >>  	.previous
> >>  
> >> +661:	nop
> >> +	nop
> >> +	.section	.sun4v_2insn_patch, "ax"
> >> +	.word		661b
> >> +	mov		SECONDARY_CONTEXT_R1, %g3
> >> +	ldxa		[%g3] ASI_MMU, %g4
> >> +	.previous
> >> +	/* Unnecessary on sun4u and pre-Niagara 2 sun4v */
> >> +	mov		SECONDARY_CONTEXT, %g3
> >> +
> >>  	sethi		%hi(sparc64_kern_sec_context), %g2
> > 
> > You missed the second instruction to patch with here.
> > This bug repeats itself further down.
> > 
> > Just noted while briefly reading the code - did not really follow the code.
> 
> Hi Sam,
> 
> This is my first sparc assembly code, so I could certainly have this
> wrong.

Nope. I was to quick in my reading and in the reply.
when I looked at this with fresh eyes it looked perfectly OK.

That is to say - the patching part. I did not follow the code logic.

	Sam