linux-kernel - Re: [PATCH] openrisc: Define __kernel_size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdVn8FKEkaNeiYaepKcaE6eofZN9kJ0u0yo0Y1X3P37Bfg@mail.gmail.com>
Date:   Wed, 21 Dec 2016 08:05:26 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Andreas Schwab <schwab@...ux-m68k.org>
Cc:     kbuild test robot <lkp@...el.com>,
        Stafford Horne <shorne@...il.com>,
        "kbuild-all@...org" <kbuild-all@...org>,
        Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
        openrisc@...ts.librecores.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] openrisc: Define __kernel_size_t to suppress compiler warnings

On Tue, Dec 20, 2016 at 11:44 PM, Andreas Schwab <schwab@...ux-m68k.org> wrote:
> On Dez 20 2016, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>> When I saw this patch, I was already a bit skeptical about it, but I noticed
>> other architectures (e.g. avr32) are doing the same, so I didn't reply.
>>
>> In my experience, "format '%zu' expects argument of type 'size_t', but
>> argument 3 has type 'unsigned int'" happens when using a compiler that
>> was not configured to use the correct type (should be unsigned long) for
>> size_t. Typically this happens when using a compiler not configured for
>> a Linux target.
>
> 32-bit targets typically use unsigned int for size_t.  It is part of the
> ABI, so all compilers must agree.  Since or32 is a out-of-tree port, and
> gcc defaults to unsigned long for size_t, mismatches can happen if
> people are using incomplete patches.

Right, thanks for correcting me!
It should indeed be unsigned int on 32-bit, and unsigned long on 64-bit.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds