linux-kernel - Re: [PATCH 1/3] perf sched timehist: Enlarge default comm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Dec 2016 10:19:26 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Jiri Olsa <jolsa@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 1/3] perf sched timehist: Enlarge default comm_width

Em Thu, Dec 22, 2016 at 03:03:48PM +0900, Namhyung Kim escreveu:
> Current default value is 20 but it's easily changed to a bigger value as
> task has a long name and different tid and pid.  And it makes the output
> not aligned.  So change it to have a large value as summary shows.

So you're doing multiple things here:

1) making more places honour the comm_width (header)

2) changing its default from 20 to 30 and due to this, removing the
   setting to 30 done at timehist_print_summary

I'll break it into two to reflect that.

- Arnaldo

> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>  tools/perf/builtin-sched.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> index c1c07bfe132c..5052caa91caa 100644
> --- a/tools/perf/builtin-sched.c
> +++ b/tools/perf/builtin-sched.c
> @@ -1775,7 +1775,7 @@ static u64 perf_evsel__get_time(struct perf_evsel *evsel, u32 cpu)
>  	return r->last_time[cpu];
>  }
>  
> -static int comm_width = 20;
> +static int comm_width = 30;
>  
>  static char *timehist_get_commstr(struct thread *thread)
>  {
> @@ -1817,7 +1817,7 @@ static void timehist_header(struct perf_sched *sched)
>  		printf(" ");
>  	}
>  
> -	printf(" %-20s  %9s  %9s  %9s",
> +	printf(" %-*s  %9s  %9s  %9s", comm_width,
>  		"task name", "wait time", "sch delay", "run time");
>  
>  	printf("\n");
> @@ -1830,7 +1830,8 @@ static void timehist_header(struct perf_sched *sched)
>  	if (sched->show_cpu_visual)
>  		printf(" %*s ", ncpus, "");
>  
> -	printf(" %-20s  %9s  %9s  %9s\n", "[tid/pid]", "(msec)", "(msec)", "(msec)");
> +	printf(" %-*s  %9s  %9s  %9s\n", comm_width,
> +	       "[tid/pid]", "(msec)", "(msec)", "(msec)");
>  
>  	/*
>  	 * separator
> @@ -1840,7 +1841,7 @@ static void timehist_header(struct perf_sched *sched)
>  	if (sched->show_cpu_visual)
>  		printf(" %.*s ", ncpus, graph_dotted_line);
>  
> -	printf(" %.20s  %.9s  %.9s  %.9s",
> +	printf(" %.*s  %.9s  %.9s  %.9s", comm_width,
>  		graph_dotted_line, graph_dotted_line, graph_dotted_line,
>  		graph_dotted_line);
>  
> @@ -2626,9 +2627,6 @@ static void timehist_print_summary(struct perf_sched *sched,
>  
>  	memset(&totals, 0, sizeof(totals));
>  
> -	if (comm_width < 30)
> -		comm_width = 30;
> -
>  	if (sched->idle_hist) {
>  		printf("\nIdle-time summary\n");
>  		printf("%*s  parent  sched-out  ", comm_width, "comm");
> -- 
> 2.10.0