linux-kernel - Re: [PATCH] MIPS: ralink: fix incorrect assignment on ralink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7ca20b25-60d8-b439-0e30-671549d641bb@phrozen.org>
Date:   Fri, 23 Dec 2016 06:38:45 +0100
From:   John Crispin <john@...ozen.org>
To:     Colin King <colin.king@...onical.com>,
        Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...ux-mips.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: ralink: fix incorrect assignment on ralink_soc



On 23/12/2016 00:52, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> ralink_soc sould be assigned to RT3883_SOC, replace incorrect
> comparision with assignment.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
Acked-by: John Crispin <john@...ozen.org>

i thought i had sent this fix upstream ages ago. luckily this bug never
caused any error as none of the code checking ralink_soc checks for
rt3883. its used for the rt3x5x family.

	John


> ---
>  arch/mips/ralink/rt3883.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/ralink/rt3883.c b/arch/mips/ralink/rt3883.c
> index 141c597..f869052 100644
> --- a/arch/mips/ralink/rt3883.c
> +++ b/arch/mips/ralink/rt3883.c
> @@ -157,5 +157,5 @@ void prom_soc_init(struct ralink_soc_info *soc_info)
>  
>  	rt2880_pinmux_data = rt3883_pinmux_data;
>  
> -	ralink_soc == RT3883_SOC;
> +	ralink_soc = RT3883_SOC;
>  }
> 
his