linux-kernel - Re: [Intel-gfx] [PATCH] drm/i915: check if execlist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161223075121.GB14877@nuc-i3427.alporthouse.com>
Date:   Fri, 23 Dec 2016 07:51:21 +0000
From:   Chris Wilson <chris@...is-wilson.co.uk>
To:     changbin.du@...el.com
Cc:     daniel.vetter@...el.com, airlied@...ux.ie,
        intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: check if execlist_port is empty
 before using its content

On Fri, Dec 23, 2016 at 01:46:36PM +0800, changbin.du@...el.com wrote:
> From: "Du, Changbin" <changbin.du@...el.com>
> 
> This patch fix a crash in function reset_common_ring. In this case,
> the port[0].request is null when reset the render ring, so a null
> dereference exception is raised. We need to check execlist_port status
> first.

No. The root cause is whatever got you into the illegal condition in the
first place.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre