linux-kernel - Re: [PATCH] mtd: nand: xway: fix build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Dec 2016 10:07:23 +0100
From:   Marek Vasut <marek.vasut@...il.com>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Cyrille Pitchen <cyrille.pitchen@...el.com>
Cc:     linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH] mtd: nand: xway: fix build failure

On 12/23/2016 09:17 AM, Sudip Mukherjee wrote:
> The build of mips xway_defconfig was failing with the error:
> 
> drivers/mtd/nand/xway_nand.c:235:1: warning:
> 	data definition has no type or storage class
>  MODULE_DEVICE_TABLE(of, xway_nand_match);
>  ^~~~~~~~~~~~~~~~~~~
> drivers/mtd/nand/xway_nand.c:235:1: error:
> 	type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
> 		[-Werror=implicit-int]
> 
> It missed to include the header file.
> 
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>

Acked-by: Marek Vasut <marex@...x.de>

> ---
> 
> Build log of next-20161223 is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/186246753
> 
> This error will be fixed but it will now uncover the next error as the
> build goes on.
> 
>  drivers/mtd/nand/xway_nand.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/nand/xway_nand.c b/drivers/mtd/nand/xway_nand.c
> index 1f2948c..00168d6 100644
> --- a/drivers/mtd/nand/xway_nand.c
> +++ b/drivers/mtd/nand/xway_nand.c
> @@ -7,6 +7,7 @@
>   *  Copyright © 2016 Hauke Mehrtens <hauke@...ke-m.de>
>   */
>  
> +#include <linux/module.h>
>  #include <linux/mtd/nand.h>
>  #include <linux/of_gpio.h>
>  #include <linux/of_platform.h>
> 


-- 
Best regards,
Marek Vasut