linux-kernel - Re: [PATCH] tools build: replace $(CC) -E with $(CPP) for pre-processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161223105947.GA5944@krava>
Date:   Fri, 23 Dec 2016 11:59:47 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Arnaldo Carvalho de Melo <acme@...hat.com>,
        Jiri Olsa <jolsa@...nel.org>, Wang Nan <wangnan0@...wei.com>,
        linux-kernel@...r.kernel.org, Michal Marek <mmarek@...e.com>
Subject: Re: [PATCH] tools build: replace $(CC) -E with $(CPP) for
 pre-processing

On Fri, Dec 23, 2016 at 01:46:42PM +0900, Masahiro Yamada wrote:
> The top-level Makefile defines:
> 
>   CPP             = $(CC) -E

hum, so that'd work for running from top level, but I guess
it fails for compiling from other places..? like tools/perf

jirka

> 
> So, $(CC) -E can be replaced with $(CPP) and this makes more sense
> for pre-processing.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
>  tools/build/Makefile.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
> index 99c0ccd..4a0ec5c 100644
> --- a/tools/build/Makefile.build
> +++ b/tools/build/Makefile.build
> @@ -65,7 +65,7 @@ quiet_cmd_cxx_o_c = CXX      $@
>        cmd_cxx_o_c = $(CXX) $(cxx_flags) -c -o $@ $<
>  
>  quiet_cmd_cpp_i_c = CPP      $@
> -      cmd_cpp_i_c = $(CC) $(c_flags) -E -o $@ $<
> +      cmd_cpp_i_c = $(CPP) $(c_flags) -o $@ $<
>  
>  quiet_cmd_cc_s_c = AS       $@
>        cmd_cc_s_c = $(CC) $(c_flags) -S -o $@ $<
> -- 
> 2.7.4
>