lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 23 Dec 2016 17:32:53 +0100
From:   Tomas Henzl <thenzl@...hat.com>
To:     Sasikumar Chandrasekaran <sasikumar.pc@...adcom.com>,
        jejb@...nel.org, hch@...radead.org
Cc:     linux-scsi@...r.kernel.org, Sathya.Prakash@...adcom.com,
        linux-kernel@...r.kernel.org, christopher.owens@...adcom.com,
        kiran-kumar.kasturi@...adcom.com
Subject: Re: [PATCH V6 00/11] megaraid_sas: Updates for scsi-next

On 23.12.2016 16:24, Tomas Henzl wrote:
> On 23.12.2016 02:19, Sasikumar Chandrasekaran wrote:
>> Sasikumar Chandrasekaran (11):
>>   megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid
>>     Controllers
>>   megaraid_sas: 128 MSIX Support
>>   megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid
>>     Controllers
>>   megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and
>>     IO Coalescing
>>   megaraid_sas: SAS3.5 Generic Megaraid Controllers Fast Path for RAID
>>     1/10 Writes
>>   megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid
>>     Controllers
>>   megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers
>>     Capabilities
>>   megaraid_sas: Enable or Disable Fast path based on the PCI Threshold
>>     Bandwidth
>>   megaraid_sas: ldio_outstanding variable is not decremented in
>>     completion path
>>   megaraid_sas: Implement the PD Map support for SAS3.5 Generic Megaraid
>>     Controllers
>>   megaraid_sas: driver version upgrade
>>
>>  drivers/scsi/megaraid/megaraid_sas.h        | 139 ++++--
>>  drivers/scsi/megaraid/megaraid_sas_base.c   | 240 +++++++--
>>  drivers/scsi/megaraid/megaraid_sas_fp.c     | 341 +++++++++++--
>>  drivers/scsi/megaraid/megaraid_sas_fusion.c | 750 +++++++++++++++++++++++-----
>>  drivers/scsi/megaraid/megaraid_sas_fusion.h | 364 ++++++++++++--
>>  5 files changed, 1557 insertions(+), 277 deletions(-)
>>
> I finished review of this set and ack-ed it.
> There still is a large amount (~1600) of checkpatch errors,
> ERROR: DOS line endings
> ERROR: trailing whitespace
> ...
> I complained about this several times and was hoping that Sasi would fix all that in V6
> but for some reason it hasn't been fixed.
> I don't want to stop the series only because of formatting issues,
> so well ok
> -tm

I looked into this once again and I think now, that the issue 
with the 'line endings' is an issue on my side. 
I'm sorry for that and please ignore my previous comment.
-tm

>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


Powered by blists - more mailing lists