linux-kernel - Re: [PATCH] pci: hotplug: This patch removes unnecessary return statement using spatch tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1482565780.1928.1.camel@perches.com>
Date:   Fri, 23 Dec 2016 23:49:40 -0800
From:   Joe Perches <joe@...ches.com>
To:     Rahul Krishnan <mrahul.krishnan@...il.com>, bhelgaas@...gle.com
Cc:     mpe@...erman.id.au, mika.westerberg@...ux.intel.com,
        gwshan@...ux.vnet.ibm.com, mayurkumar.patel@...el.com,
        keith.busch@...el.com, julia.lawall@...6.fr,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pci: hotplug: This patch removes unnecessary return
 statement using spatch tool

On Sat, 2016-12-24 at 13:03 +0530, Rahul Krishnan wrote:
> This patch removes unnecessary return statement using spatch tool
[]
> diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c
[]
> @@ -463,8 +463,7 @@ int __init rpadlpar_io_init(void)
>  		return -EPERM;
>  	}
>  
> -	rc = dlpar_sysfs_init();
> -	return rc;
> +	return dlpar_sysfs_init();
>  }
>  
>  void rpadlpar_io_exit(void)

If you are going to submit these types
of patches, please make sure you compile
test them before sending so that you can
look at new warnings.

Now rc is unused and its declaration
should be removed.