lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 24 Dec 2016 17:52:58 +0100 From: Pali Rohár <pali.rohar@...il.com> To: Ming Lei <ming.lei@...onical.com>, "Luis R. Rodriguez" <mcgrof@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Kalle Valo <kvalo@...eaurora.org>, David Gnedt <david.gnedt@...izone.at>, Michal Kazior <michal.kazior@...to.com>, Daniel Wagner <wagi@...om.org>, Tony Lindgren <tony@...mide.com>, Sebastian Reichel <sre@...nel.org>, Pavel Machek <pavel@....cz>, Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>, Aaro Koskinen <aaro.koskinen@....fi>, Grazvydas Ignotas <notasas@...il.com> Cc: linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, Pali Rohár <pali.rohar@...il.com> Subject: [PATCH 3/6] wl1251: Update wl->nvs_len after wl->nvs is valid In case kmemdup fails thne wl->nvs_len will contains invalid non-zero size. This patch fixes it. Signed-off-by: Pali Rohár <pali.rohar@...il.com> --- drivers/net/wireless/ti/wl1251/main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ti/wl1251/main.c b/drivers/net/wireless/ti/wl1251/main.c index 24f8866..8971b64 100644 --- a/drivers/net/wireless/ti/wl1251/main.c +++ b/drivers/net/wireless/ti/wl1251/main.c @@ -124,8 +124,7 @@ static int wl1251_fetch_nvs(struct wl1251 *wl) goto out; } - wl->nvs_len = fw->size; - wl->nvs = kmemdup(fw->data, wl->nvs_len, GFP_KERNEL); + wl->nvs = kmemdup(fw->data, fw->size, GFP_KERNEL); if (!wl->nvs) { wl1251_error("could not allocate memory for the nvs file"); @@ -133,6 +132,8 @@ static int wl1251_fetch_nvs(struct wl1251 *wl) goto out; } + wl->nvs_len = fw->size; + ret = 0; out: -- 1.7.9.5
Powered by blists - more mailing lists