lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 25 Dec 2016 22:34:54 +0000 From: Jonathan Cameron <jic23@...23.retrosnub.co.uk> To: Al Viro <viro@...IV.linux.org.uk>, Scott Matheina <scott@...heina.com> CC: linux-kernel@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, Jonathan Cameron <jic23@...nel.org>, Hartmut Knaack <knaack.h@....de>, Peter Meerwald-Stadler <pmeerw@...erw.net>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-iio@...r.kernel.org, devel@...verdev.osuosl.org Subject: Re: [PATCHv4 2/8] Fixed variables not being consistently lower case On 25 December 2016 20:14:09 GMT+00:00, Al Viro <viro@...IV.linux.org.uk> wrote: >On Sun, Dec 25, 2016 at 01:41:06PM -0600, Scott Matheina wrote: >> Across the file, variables were sometimes upper case, some times >> lower case, this fix addresses a few of the instances with this >> inconsistency. > >NAK. Go learn C and don't come back until you've done that. If >somebody >has told you that you can contribute without knowing the language, >they'd >lied - you really can't. And I would *STRONGLY* recommend to stay away >from drivers/staging while you are learning C - it's like trying to use >a public restroom wall as a sex-ed textbook. Please can we keep things polite. Jonathan > >While we are at it, it might be a good idea to check if the kernel >builds after your changes and see what errors are produced. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
Powered by blists - more mailing lists