lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 25 Dec 2016 15:15:52 +0100 From: Jethro Beekman <kernel@...ekman.nl> To: Scott Bauer <scott.bauer@...el.com>, linux-nvme@...ts.infradead.org Cc: Rafael.Antognolli@...el.com, axboe@...com, keith.busch@...el.com, jonathan.derrick@...el.com, viro@...iv.linux.org.uk, hch@...radead.org, linux-kernel@...r.kernel.org, sagi@...mberg.me Subject: Re: [PATCH v3 4/5] nvme: Implement resume_from_suspend and SED Allocation code. On 19-12-16 20:35, Scott Bauer wrote: > @@ -1796,6 +1797,13 @@ static void nvme_reset_work(struct work_struct *work) > if (result) > goto out; > > + result = nvme_opal_initialize(&dev->ctrl); > + if (result) > + goto out; It seems you always try to intialize OPAL even if the drive doesn't support it. I think you should check if the device supports security commands and then see if it supports OPAL before calling this. See e.g. https://lkml.org/lkml/2016/6/19/139 . Ideally, this code would check all supported protocols and initialize the appropriate security device based on that. Jethro
Powered by blists - more mailing lists