linux-kernel - Re: [PATCH] iio: mxs-lradc: fix error handling in mxs_lradc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1600801097.88831.1482789844722@email.1und1.de>
Date:   Mon, 26 Dec 2016 23:04:04 +0100 (CET)
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     Alexey Khoroshilov <khoroshilov@...ras.ru>,
        Jonathan Cameron <jic23@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org,
        linux-iio@...r.kernel.org, lee.jones@...aro.org
Subject: Re: [PATCH] iio: mxs-lradc: fix error handling in mxs_lradc_probe()


> Alexey Khoroshilov <khoroshilov@...ras.ru> hat am 23. Dezember 2016 um 23:15 geschrieben:
> 
> 
> During transition to using devm_input_allocate_device()
> goto to resource deallocation block was replaced by return
> in case of error in iio_device_register().
> That is wrong since resources are left undeallocated.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>
> Fixes: 962ed43a3eac ("iio: mxs-lradc: remove mxs_lradc_ts_unregister")

Acked-by: Stefan Wahren <stefan.wahren@...e.com>

But since Ksenija's patch series [1] (which doesn't have this issue) this patch is only relevant for stable.

Thanks

[1] - http://marc.info/?l=linux-iio&m=148131774219426&w=2