linux-kernel - Re: [PATCH] drivers: watchdog: pika_wdt: add __ro_after

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <182d4c22-53d1-5b93-5eb5-2763005a94be@roeck-us.net>
Date:   Mon, 26 Dec 2016 02:39:35 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Bhumika Goyal <bhumirks@...il.com>, julia.lawall@...6.fr,
        wim@...ana.be, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     keescook@...omium.org
Subject: Re: [PATCH] drivers: watchdog: pika_wdt: add __ro_after_init to ident

On 12/25/2016 12:00 AM, Bhumika Goyal wrote:
> The object ident of type watchdog_info structure is not
> modified after getting initialized by pikawdt_init. Apart from getting
> referenced in init it is also passed as an argument to the function
> copy_to_user but this argument is of type const void *. Therefore add
> __ro_after_init to its declaration.
>
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/pika_wdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/pika_wdt.c b/drivers/watchdog/pika_wdt.c
> index 0cdfee2..e35cf5e 100644
> --- a/drivers/watchdog/pika_wdt.c
> +++ b/drivers/watchdog/pika_wdt.c
> @@ -54,7 +54,7 @@
>  	struct timer_list timer;	/* The timer that pings the watchdog */
>  } pikawdt_private;
>
> -static struct watchdog_info ident = {
> +static struct watchdog_info ident __ro_after_init = {
>  	.identity	= DRV_NAME,
>  	.options	= WDIOF_CARDRESET |
>  			  WDIOF_SETTIMEOUT |
>