linux-kernel - Re: [PATCH v3] mach-omap2: fixing wrong strcat for Non-NULL terminated string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161227174018.GT4920@atomide.com>
Date:   Tue, 27 Dec 2016 09:40:18 -0800
From:   Tony Lindgren <tony@...mide.com>
To:     Maninder Singh <maninder1.s@...sung.com>
Cc:     bcousson@...libre.com, paul@...an.com, linux@...linux.org.uk,
        linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, pankaj.m@...sung.com,
        ajeet.y@...sung.com, Vaneet Narang <v.narang@...sung.com>
Subject: Re: [PATCH v3] mach-omap2: fixing wrong strcat for Non-NULL
 terminated string

* Maninder Singh <maninder1.s@...sung.com> [161207 20:16]:
> Issue caught with static analysis tool:
> "Dangerous usage of 'name' (strncpy doesn't always 0-terminate it)"
> 
> Use strlcpy _includes_ the NUL terminator, and  strlcat() which ensures 
> that it won't overflow the buffer.

Applying into omap-for-v4.10/fixes thanks.

Tony