linux-kernel - Re: [PATCH v3 2/2] drivers: net: ethernet: 3com: fix return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1482873453.20986.4.camel@dillow-glaptop.roam.corp.google.com>
Date:   Tue, 27 Dec 2016 13:17:33 -0800
From:   David Dillow <dave@...dillows.org>
To:     Thomas Preisner <thomas.preisner+linux@....de>
Cc:     sergei.shtylyov@...entembedded.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-kernel@...cs.fau.de,
        milan.stephan+linux@....de
Subject: Re: [PATCH v3 2/2] drivers: net: ethernet: 3com: fix return value

On Sun, 2016-12-25 at 01:30 +0100, Thomas Preisner wrote:
> In some cases the return value of a failing function is not being used
> and the function typhoon_init_one() returns another negative error
> code instead.

I'm not sure these changes are especially valuable, since we'll need to
look at the dmesg log anyways to figure out what went wrong, but again I
don't feel strongly.

Fix up the subject issues and I'm happy to ack them.