linux-kernel - Re: [PATCH 1/1] [media] v4l: rcar_fdp1: use %4.4s to format a 4-byte string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <63afb58e-e588-c3f0-7950-2e2b5dfa453e@bingham.xyz>
Date:   Wed, 28 Dec 2016 09:47:15 +0000
From:   Kieran Bingham <kieran@...uared.org.uk>
To:     Nicolas Iooss <nicolas.iooss_linux@....org>,
        linux-media@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] [media] v4l: rcar_fdp1: use %4.4s to format a 4-byte
 string

Hi Nicolas,

Thankyou for the patch

This looks like a good catch,

On 26/12/16 13:31, Nicolas Iooss wrote:
> Using %4s to format f->fmt.pix_mp.pixelformat in fdp1_try_fmt() and
> fdp1_s_fmt() may lead to more characters being printed (when the byte
> following field pixelformat is not zero).
> 
> Add ".4" to the format specifier to limit the number of printed
> characters to four. The resulting format specifier "%4.4s" is also used
> by other media drivers to print pixelformat value.
> 
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@....org>

Reviewed-by: Kieran Bingham <kieran@...gham.xyz>

> ---
>  drivers/media/platform/rcar_fdp1.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/rcar_fdp1.c b/drivers/media/platform/rcar_fdp1.c
> index 674cc1309b43..42f25d241edd 100644
> --- a/drivers/media/platform/rcar_fdp1.c
> +++ b/drivers/media/platform/rcar_fdp1.c
> @@ -1596,7 +1596,7 @@ static int fdp1_try_fmt(struct file *file, void *priv, struct v4l2_format *f)
>  	else
>  		fdp1_try_fmt_capture(ctx, NULL, &f->fmt.pix_mp);
>  
> -	dprintk(ctx->fdp1, "Try %s format: %4s (0x%08x) %ux%u field %u\n",
> +	dprintk(ctx->fdp1, "Try %s format: %4.4s (0x%08x) %ux%u field %u\n",
>  		V4L2_TYPE_IS_OUTPUT(f->type) ? "output" : "capture",
>  		(char *)&f->fmt.pix_mp.pixelformat, f->fmt.pix_mp.pixelformat,
>  		f->fmt.pix_mp.width, f->fmt.pix_mp.height, f->fmt.pix_mp.field);
> @@ -1671,7 +1671,7 @@ static int fdp1_s_fmt(struct file *file, void *priv, struct v4l2_format *f)
>  
>  	fdp1_set_format(ctx, &f->fmt.pix_mp, f->type);
>  
> -	dprintk(ctx->fdp1, "Set %s format: %4s (0x%08x) %ux%u field %u\n",
> +	dprintk(ctx->fdp1, "Set %s format: %4.4s (0x%08x) %ux%u field %u\n",
>  		V4L2_TYPE_IS_OUTPUT(f->type) ? "output" : "capture",
>  		(char *)&f->fmt.pix_mp.pixelformat, f->fmt.pix_mp.pixelformat,
>  		f->fmt.pix_mp.width, f->fmt.pix_mp.height, f->fmt.pix_mp.field);
> 

-- 
Regards

Kieran Bingham