linux-kernel - Re: [PATCH net] net: stmmac: Fix race between stmmac_drv_probe and stmmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161227.213244.1031537802471524150.davem@davemloft.net>
Date:   Tue, 27 Dec 2016 21:32:44 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, pavel@....cz, Joao.Pinto@...opsys.com,
        seraphin.bonnaffe@...com, alexandre.torgue@...il.com,
        manabian@...il.com, niklas.cassel@...s.com, johan@...nel.org,
        boon.leong.ong@...el.com, weifeng.voon@...el.com,
        lars.persson@...s.com, linux-kernel@...r.kernel.org,
        peppe.cavallaro@...com, alexandre.torgue@...com
Subject: Re: [PATCH net] net: stmmac: Fix race between stmmac_drv_probe and
 stmmac_open

From: Florian Fainelli <f.fainelli@...il.com>
Date: Tue, 27 Dec 2016 18:23:06 -0800

> There is currently a small window during which the network device registered by
> stmmac can be made visible, yet all resources, including and clock and MDIO bus
> have not had a chance to be set up, this can lead to the following error to
> occur:
 ...
> Fix this by making sure that register_netdev() is the last thing being done,
> which guarantees that the clock and the MDIO bus are available.
> 
> Fixes: 4bfcbd7abce2 ("stmmac: Move the mdio_register/_unregister in probe/remove")
> Reported-by: Kweh, Hock Leong <hock.leong.kweh@...el.com>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied and queued up for -stable, thanks Florian.