linux-kernel - Re: [PATCH 1/2] ALSA: hda - Apply ALC269_FIXUP_NO_SHUTUP on HDA_FIXUP_ACT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hpokculv8.wl-tiwai@suse.de>
Date:   Wed, 28 Dec 2016 16:14:19 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Gabriele Mazzotta" <gabriele.mzt@...il.com>
Cc:     <perex@...ex.cz>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] ALSA: hda - Apply ALC269_FIXUP_NO_SHUTUP on HDA_FIXUP_ACT_PROBE

On Sat, 24 Dec 2016 19:50:00 +0100,
Gabriele Mazzotta wrote:
> 
> Setting shutup when the action is HDA_FIXUP_ACT_PRE_PROBE might
> not have the desired effect since it could be overridden by
> another more generic shutup function. Prevent this by setting
> the more specific shutup function on HDA_FIXUP_ACT_PROBE.
> 
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@...il.com>

Applied both patches now.  Thanks.


Takashi

> ---
>  sound/pci/hda/patch_realtek.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index ea81c08ddc7a..d30cc49512e4 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4400,7 +4400,7 @@ static void alc_no_shutup(struct hda_codec *codec)
>  static void alc_fixup_no_shutup(struct hda_codec *codec,
>  				const struct hda_fixup *fix, int action)
>  {
> -	if (action == HDA_FIXUP_ACT_PRE_PROBE) {
> +	if (action == HDA_FIXUP_ACT_PROBE) {
>  		struct alc_spec *spec = codec->spec;
>  		spec->shutup = alc_no_shutup;
>  	}
> -- 
> 2.11.0
> 
>