linux-kernel - Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <87eg0sf12c.fsf@linux-m68k.org>
Date:   Wed, 28 Dec 2016 17:52:43 +0100
From:   Andreas Schwab <schwab@...ux-m68k.org>
To:     Timur Tabi <timur@...i.org>
Cc:     "Harisangam\, Sharvari \(S.\)" <sharvari.harisangam@...teon.com>,
        "alsa-devel\@alsa-project.org" <alsa-devel@...a-project.org>,
        Xiubo Li <Xiubo.Lee@...il.com>, Takashi Iwai <tiwai@...e.de>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Nicolin Chen <nicoleotsuka@...il.com>,
        Mark Brown <broonie@...nel.org>,
        "linuxppc-dev\@lists.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode

On Dez 28 2016, Timur Tabi <timur@...i.org> wrote:

> Andreas Schwab wrote:
>>> > +	return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) ==
>>> > +		SND_SOC_DAIFMT_AC97;
>> This is never true.
>
> I think the right parenthesis should be at the end of the expression.

That would still test the wrong bitfield.

And all that is obsolete anyway since commit 5b64c173cd (of Sep 2015).

Andreas.

-- 
Andreas Schwab, schwab@...ux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."