lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Dec 2016 10:42:40 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: "Kweh, Hock Leong" <hock.leong.kweh@...el.com>, David Miller <davem@...emloft.net> Cc: "Joao.Pinto@...opsys.com" <Joao.Pinto@...opsys.com>, "peppe.cavallaro@...com" <peppe.cavallaro@...com>, "seraphin.bonnaffe@...com" <seraphin.bonnaffe@...com>, "alexandre.torgue@...il.com" <alexandre.torgue@...il.com>, "manabian@...il.com" <manabian@...il.com>, "niklas.cassel@...s.com" <niklas.cassel@...s.com>, "johan@...nel.org" <johan@...nel.org>, "pavel@....cz" <pavel@....cz>, "Ong, Boon Leong" <boon.leong.ong@...el.com>, "Voon, Weifeng" <weifeng.voon@...el.com>, "lars.persson@...s.com" <lars.persson@...s.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and stmmac_dvr_probe On 12/27/2016 09:49 PM, Kweh, Hock Leong wrote: >> -----Original Message----- >> From: David Miller [mailto:davem@...emloft.net] >> Sent: Wednesday, December 28, 2016 12:34 AM >> To: Kweh, Hock Leong <hock.leong.kweh@...el.com> >> Cc: Joao.Pinto@...opsys.com; peppe.cavallaro@...com; >> seraphin.bonnaffe@...com; f.fainelli@...il.com; >> alexandre.torgue@...il.com; manabian@...il.com; niklas.cassel@...s.com; >> johan@...nel.org; pavel@....cz; Ong, Boon Leong >> <boon.leong.ong@...el.com>; Voon, Weifeng <weifeng.voon@...el.com>; >> lars.persson@...s.com; netdev@...r.kernel.org; linux-kernel@...r.kernel.org >> Subject: Re: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and >> stmmac_dvr_probe >> >> From: "Kweh, Hock Leong" <hock.leong.kweh@...el.com> >> Date: Tue, 27 Dec 2016 22:42:36 +0800 >> >>> From: "Kweh, Hock Leong" <hock.leong.kweh@...el.com> >> >> You are not the author of this change, do not take credit for it. >> >> You have copied Florian's patch character by character, therefore >> he is the author. >> >> You also didn't CC: the netdev mailing list properly. > > Hi David & Florian, > > Just to clarify that I do not copy exactly from Florian. > I have changed it to have proper handling on mdio unregister > while netdev_register() failed as showed below: > > return 0; > > -error_mdio_register: > - unregister_netdev(ndev); > error_netdev_register: > + stmmac_mdio_unregister(ndev); Although this is required, we can't be doing it in all circumstances, we need to mimic what stmmac_drv_remove() does. Let me submit an incremental fix which takes care of mdio bus unregistration. -- Florian
Powered by blists - more mailing lists