linux-kernel - Re: [PATCH 00/15] hyperv: more stuff to uapi + cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161228165700.GA14702@rkaganb.sw.ru>
Date:   Wed, 28 Dec 2016 19:57:00 +0300
From:   Roman Kagan <rkagan@...tuozzo.com>
To:     KY Srinivasan <kys@...rosoft.com>
CC:     Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        "x86@...nel.org" <x86@...nel.org>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "Denis V . Lunev" <den@...nvz.org>
Subject: Re: [PATCH 00/15] hyperv: more stuff to uapi + cleanup

[ Sorry for such a slow reply; flu and office relocation knocked me out
for a while ]

On Wed, Dec 21, 2016 at 06:00:17PM +0000, KY Srinivasan wrote:
> > -----Original Message-----
> > From: Roman Kagan [mailto:rkagan@...tuozzo.com]
> > Sent: Tuesday, December 20, 2016 7:56 AM
> > Subject: [PATCH 00/15] hyperv: more stuff to uapi + cleanup
> > 
> > Expose more Hyper-V-related definitions in the uapi header for
> > consumption by userspace.
> > 
> > While doing so, get rid of a number of duplications between the KVM and
> > the guest driver code.  Also a few other cleanups are made which are not
> > strictly necessary for the main purpose of the series but appear
> > reasonable to do at the same time.
> > 
> > The most controversial is the last patch which modifies the stuff
> > already published in the uapi header, in the hope that no userspace
> > applications have started relying on it; I'm ok dropping it if this is
> > unacceptable.
> 
> First, let me thank you. Broadly, this patch-set can be broken into
> 1. Moving existing definitions around - (to make it possible to share these
> between Hyper-V guest drivers and KVM)
> 2. Cleanup of the existing code in the VMBUS driver (under drivers/hv).

Right.  Another significant part of the series is, where two sets of
definitions exist for the same entity, consolidate on the one that looks
more Linux-style, usually the one in the (currently) uapi header.

> To the extent possible, I want to take all non-KVM code through Greg's tree.
> We can then modify the KVM code to use these common definitions.

Well, this patchset touches almost no KVM code, so we're fine here I
think.

> Currently, I too am working on restructuring VMBUS driver code to
> fully isolate all x86 dependencies.  I can work with you on
> integration as I too am moving things around.

Great!  Do you want me to rebase on some your public tree?  (Once I
split the patches as you requested, of course)?

Thanks,
Roman.