linux-kernel - Re: [PATCH] platform/x86: fix surface3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Dec 2016 22:45:28 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Darren Hart <dvhart@...radead.org>,
        kbuild test robot <fengguang.wu@...el.com>,
        Benjamin Tissoires <benjamin.tissoires@...il.com>
Subject: Re: [PATCH] platform/x86: fix surface3_button build errors

On Wed, Dec 28, 2016 at 12:28 AM, Randy Dunlap <rdunlap@...radead.org> wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
>
> Fix build errors when I2C=m and SURFACE_3_BUTTON=y.
> The driver uses i2c interfaces so it should depend on I2C.
>
> drivers/built-in.o: In function `surface3_driver_init':
> surface3_button.c:(.init.text+0x75cb0): undefined reference to `i2c_register_driver'
> drivers/built-in.o: In function `surface3_driver_exit':
> surface3_button.c:(.exit.text+0x31a8): undefined reference to `i2c_del_driver'
>
> Fixes: 1a64b719d3ae (platform/x86: Introduce button support for the Surface 3)
>

Pushed to fixes.
Thanks!

> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Cc: Benjamin Tissoires <benjamin.tissoires@...il.com>
> Cc: platform-driver-x86@...r.kernel.org
> Cc: Darren Hart <dvhart@...radead.org>
> ---
>  drivers/platform/x86/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- lnx-410-rc1.orig/drivers/platform/x86/Kconfig
> +++ lnx-410-rc1/drivers/platform/x86/Kconfig
> @@ -1034,7 +1034,7 @@ config SURFACE_PRO3_BUTTON
>
>  config SURFACE_3_BUTTON
>         tristate "Power/home/volume buttons driver for Microsoft Surface 3 tablet"
> -       depends on ACPI && KEYBOARD_GPIO
> +       depends on ACPI && KEYBOARD_GPIO && I2C
>         ---help---
>           This driver handles the power/home/volume buttons on the Microsoft Surface 3 tablet.
>



-- 
With Best Regards,
Andy Shevchenko