linux-kernel - Re: [RESEND PATCH V3 4/4] gpio: pv88080: Add GPIO function support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkda1_SVGLeK9rgkpVj-6vj_WKZnAyOJp_Z775o88+wo49A@mail.gmail.com>
Date:   Wed, 28 Dec 2016 01:28:25 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Eric Jeong <eric.jeong.opensource@...semi.com>
Cc:     Alexandre Courbot <gnurou@...il.com>,
        LINUX-GPIO <linux-gpio@...r.kernel.org>,
        LINUX-KERNEL <linux-kernel@...r.kernel.org>,
        DEVICETREE <devicetree@...r.kernel.org>,
        Lee Jones <lee.jones@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Support Opensource <support.opensource@...semi.com>
Subject: Re: [RESEND PATCH V3 4/4] gpio: pv88080: Add GPIO function support

On Tue, Dec 6, 2016 at 6:33 AM, Eric Jeong
<eric.jeong.opensource@...semi.com> wrote:

> From: Eric Jeong <eric.jeong.opensource@...semi.com>
>
> This patch adds support for PV88080 PMIC GPIOs.
> PV88080 has two configurable GPIOs.
>
> Kconfig and Makefile are updated to reflect support
> for PV88080 PMIC GPIO.
>
> Signed-off-by: Eric Jeong <eric.jeong.opensource@...semi.com>

> +#include <linux/gpio.h>

Use

#include <linux/gpio/driver.h>

only.

> +#include <linux/mfd/pv88080.h>

I see this header is not yet upstream so I can't merge
this driver (else I would just correct the above and merge it).

With the oneliner change:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

I guess Lee needs to merge this with the MFD bits.

Yours,
Linus Walleij