linux-kernel - Re: [RESEND] thermal: hwmon: Properly report critical temperature in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPess6_N2VyZDviS2Y8gxwsRKrG9jKuyEacE8xo2-7LaAw@mail.gmail.com>
Date:   Thu, 29 Dec 2016 13:45:49 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Zhang Rui <rui.zhang@...el.com>
Cc:     Eduardo Valentin <edubezval@...il.com>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [RESEND] thermal: hwmon: Properly report critical temperature in sysfs

On Thu, Dec 29, 2016 at 1:43 PM, Zhang Rui <rui.zhang@...el.com> wrote:
> On Wed, 2016-12-28 at 19:35 +0200, Krzysztof Kozlowski wrote:
>> In the critical sysfs entry the thermal hwmon was returning wrong
>> temperature to the user-space.  It was reporting the temperature of
>> the
>> first trip point instead of the temperature of critical trip point.
>>
>> For example:
>>       /sys/class/hwmon/hwmon0/temp1_crit:50000
>>       /sys/class/thermal/thermal_zone0/trip_point_0_temp:50000
>>       /sys/class/thermal/thermal_zone0/trip_point_0_type:active
>>       /sys/class/thermal/thermal_zone0/trip_point_3_temp:120000
>>       /sys/class/thermal/thermal_zone0/trip_point_3_type:critical
>>
>> Since commit e68b16abd91d ("thermal: add hwmon sysfs I/F") the driver
>> have been registering a sysfs entry if get_crit_temp() callback was
>> provided.  However when accessed, it was calling get_trip_temp()
>> instead
>> of the get_crit_temp().
>>
>> Fixes: e68b16abd91d ("thermal: add hwmon sysfs I/F")
>> Cc: <stable@...r.kernel.org>
>> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
>
> The patch is already in upstream kernel.
>
> thanks,
> rui

Ahh, indeed.

Thanks!
Krzysztof