linux-kernel - Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161228155321.GA19963@ubuntu>
Date:   Wed, 28 Dec 2016 15:53:33 +0000
From:   "Harisangam, Sharvari (S.)" <sharvari.harisangam@...teon.com>
To:     Andreas Schwab <schwab@...ux-m68k.org>
CC:     Timur Tabi <timur@...i.org>, Nicolin Chen <nicoleotsuka@...il.com>,
        "Xiubo Li" <Xiubo.Lee@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH]  ASoC : fsl_ssi : Correct the condition to check AC97
 mode

On Wed, Dec 28, 2016 at 03:50:57PM +0100, Andreas Schwab wrote:
> On Dez 28 2016, "Harisangam, Sharvari (S.)" <sharvari.harisangam@...teon.com> wrote:
> 
> > +	return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) ==
> > +		SND_SOC_DAIFMT_AC97;
> 
> This is never true.
> 
> Andreas.
> 
> -- 
> Andreas Schwab, schwab@...ux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
> "And now for something completely different."

Ok. I missed the braces there. I will modify and resubmit the patch

-Thanks
Sharvari