linux-kernel - Re: [PATCH v4 20/20] futex: Dump internal futex state via debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Dec 2016 02:55:01 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Waiman Long <longman@...hat.com>
Cc:     kbuild-all@...org, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Jonathan Corbet <corbet@....net>, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Davidlohr Bueso <dave@...olabs.net>,
        Mike Galbraith <umgwanakikbuti@...il.com>,
        Scott J Norton <scott.norton@....com>,
        Waiman Long <longman@...hat.com>
Subject: Re: [PATCH v4 20/20] futex: Dump internal futex state via debugfs

Hi Waiman,

[auto build test WARNING on linus/master]
[also build test WARNING on v4.10-rc1 next-20161224]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Waiman-Long/futex-Introducing-throughput-optimized-TP-futexes/20161230-020021
config: i386-randconfig-x006-201652 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   kernel/futex.c: In function 'futex_dump_show':
>> kernel/futex.c:4444:33: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'int' [-Wformat=]
     seq_printf(m, "\nHash bucket %ld:\n", hb - futex_queues);
                                    ^
   kernel/futex.c: In function 'futex_lock':
   kernel/futex.c:3796:13: warning: 'rspin_timeout' may be used uninitialized in this function [-Wmaybe-uninitialized]
        else if (curtime > rspin_timeout)
                ^
   kernel/futex.c:3676:6: note: 'rspin_timeout' was declared here
     u64 rspin_timeout;
         ^~~~~~~~~~~~~

vim +4444 kernel/futex.c

  4428	
  4429	#if defined(CONFIG_DEBUG_FS) && defined(CONFIG_SMP)
  4430	/*
  4431	 * Debug code to dump selected content of in-kernel futex hash bucket table.
  4432	 */
  4433	#include <linux/debugfs.h>
  4434	
  4435	static int futex_dump_show(struct seq_file *m, void *arg)
  4436	{
  4437		struct futex_hash_bucket *hb = arg;
  4438		struct futex_state *state;
  4439		int i;
  4440	
  4441		if (list_empty(&hb->fs_head))
  4442			return 0;
  4443	
> 4444		seq_printf(m, "\nHash bucket %ld:\n", hb - futex_queues);
  4445		spin_lock(&hb->fs_lock);
  4446		i = 0;
  4447		list_for_each_entry(state, &hb->fs_head, fs_list) {
  4448			seq_printf(m, "  Futex state %d\n", i++);
  4449			if (state->owner)
  4450				seq_printf(m, "    owner PID = %d\n",
  4451					   task_pid_vnr(state->owner));
  4452			if (state->mutex_owner)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (21429 bytes)