linux-kernel - Re: mm: fix typo of cache_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161229065205.GA3892@jagdpanzerIV.localdomain>
Date:   Thu, 29 Dec 2016 15:52:05 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Minchan Kim <minchan@...nel.org>
Cc:     Xishi Qiu <qiuxishi@...wei.com>, ngupta@...are.org,
        sergey.senozhatsky.work@...il.com, Linux MM <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: mm: fix typo of cache_alloc_zspage()

On (12/29/16 15:44), Minchan Kim wrote:
> On Thu, Dec 29, 2016 at 10:06:47AM +0800, Xishi Qiu wrote:
> > Signed-off-by: Xishi Qiu <qiuxishi@...wei.com>
> > ---
> >  mm/zsmalloc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> > index 9cc3c0b..2d6c92e 100644
> > --- a/mm/zsmalloc.c
> > +++ b/mm/zsmalloc.c
> > @@ -364,7 +364,7 @@ static struct zspage *cache_alloc_zspage(struct zs_pool *pool, gfp_t flags)
> >  {
> >  	return kmem_cache_alloc(pool->zspage_cachep,
> >  			flags & ~(__GFP_HIGHMEM|__GFP_MOVABLE));
> > -};
> > +}
> 
> Although it's trivial, we need descritpion.
> Please, could you resend to Andrew Morton with filling description?

I don't know... do we want to have it as a separate patch?
may be we can fold it into some other patch someday later.

	-ss