linux-kernel - [PATCH v2] ib umem: bugfix: mixed put_pid()s in ib_umem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1483000048-183875-1-git-send-email-liguozhu@hisilicon.com>
Date:   Thu, 29 Dec 2016 16:27:28 +0800
From:   Kenneth Lee <liguozhu@...ilicon.com>
To:     <dledford@...hat.com>, <sean.hefty@...el.com>,
        <hal.rosenstock@...il.com>
CC:     <robin.murphy@....com>, <jroedel@...e.de>, <egtvedt@...fundet.no>,
        <vgupta@...opsys.com>, <liguozhu@...ilicon.com>,
        <dave.hansen@...ux.intel.com>, <lstoakes@...il.com>,
        <krzk@...nel.org>, <sebott@...ux.vnet.ibm.com>,
        <markb@...lanox.com>, <linux-rdma@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: [PATCH v2] ib umem: bugfix: mixed put_pid()s in ib_umem_get()

There are two bugfixes in this patch:

1. When the execution go to the ib_umem_odp_get() path, pid should be put
   back.
2. When the memory allocation fail, the pid also should be put back before
   exit.

Signed-off-by: Kenneth Lee <liguozhu@...ilicon.com>
Reviewed-by: Haggai Eran <haggaie@...lanox.com>
---
Change from v1 to v2:
  Correcting the patch title and description

 drivers/infiniband/core/umem.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c
index 1e62a5f..4609b92 100644
--- a/drivers/infiniband/core/umem.c
+++ b/drivers/infiniband/core/umem.c
@@ -134,6 +134,7 @@ struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr,
 		 IB_ACCESS_REMOTE_ATOMIC | IB_ACCESS_MW_BIND));
 
 	if (access & IB_ACCESS_ON_DEMAND) {
+		put_pid(umem->pid);
 		ret = ib_umem_odp_get(context, umem);
 		if (ret) {
 			kfree(umem);
@@ -149,6 +150,7 @@ struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr,
 
 	page_list = (struct page **) __get_free_page(GFP_KERNEL);
 	if (!page_list) {
+		put_pid(umem->pid);
 		kfree(umem);
 		return ERR_PTR(-ENOMEM);
 	}
-- 
1.9.1