linux-kernel - Re: [PATCH 2/2 v2] ARM: i.MX25: add the optional security violation irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Dec 2016 10:44:10 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Martin Kaiser <martin@...ser.cx>
Cc:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        Sascha Hauer <kernel@...gutronix.de>,
        Juergen Borleis <jbe@...gutronix.de>,
        Lucas Stach <l.stach@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH 2/2 v2] ARM: i.MX25: add the optional security violation
 irq

On Thu, Dec 22, 2016 at 12:01:16AM +0100, Martin Kaiser wrote:
> Add the security violation irq as an optional entry to rtc-imxdi's
> device tree bindings and to i.MX25's dtsi file.
> 
> Signed-off-by: Martin Kaiser <martin@...ser.cx>
> ---
> v2:
>   - clarify that the security violation interrupt is optional
>   - use the same syntax as everwhere else for lists of interrupt numbers
> 
>  Documentation/devicetree/bindings/rtc/imxdi-rtc.txt |    5 ++++-
>  arch/arm/boot/dts/imx25.dtsi                        |    2 +-

I take DTS changes only.  Please make the bindings doc change a separate
patch, and have it go together with driver patch.  And I apply DTS patch
only after driver and bindings changes get accepted by RTC maintainer.

Shawn

>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt b/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt
> index c9d80d7..323cf26 100644
> --- a/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt
> +++ b/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt
> @@ -8,10 +8,13 @@ Required properties:
>    region.
>  - interrupts: rtc alarm interrupt
>  
> +Optional properties:
> +- interrupts: dryice security violation interrupt
> +
>  Example:
>  
>  rtc@...56000 {
>  	compatible = "fsl,imx53-rtc", "fsl,imx25-rtc";
>  	reg = <0x80056000 2000>;
> -	interrupts = <29>;
> +	interrupts = <29 56>;
>  };
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index 831d09a..331d1e1 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -560,7 +560,7 @@
>  				reg = <0x53ffc000 0x4000>;
>  				clocks = <&clks 81>;
>  				clock-names = "ipg";
> -				interrupts = <25>;
> +				interrupts = <25 56>;
>  			};
>  		};
>  
> -- 
> 1.7.10.4
>