linux-kernel - Re: [PATCH 3/5] pinctrl: core: Add generic pinctrl functions for managing groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZZ_zc2GR4+0R_1CPnwUMea6E4L7ewsQuGr91XC=dPRJw@mail.gmail.com>
Date:   Fri, 30 Dec 2016 15:28:42 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Tony Lindgren <tony@...mide.com>
Cc:     Haojian Zhuang <haojian.zhuang@...aro.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Nishanth Menon <nm@...com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linux-OMAP <linux-omap@...r.kernel.org>
Subject: Re: [PATCH 3/5] pinctrl: core: Add generic pinctrl functions for
 managing groups

On Tue, Dec 27, 2016 at 6:20 PM, Tony Lindgren <tony@...mide.com> wrote:

> We can add generic helpers for function handling for cases where the pin
> controller driver does not need to use static arrays.
>
> Signed-off-by: Tony Lindgren <tony@...mide.com>

Patch applied.

> +config GENERIC_PINMUX
> +       bool
> +       select PINMUX

I renamed this GENERIC_PINMUX_FUNCTIONS

> +       INIT_RADIX_TREE(&pctldev->pin_function_tree, GFP_KERNEL);

#ifdefed this

> +       struct radix_tree_root pin_function_tree;
>         unsigned int num_groups;
> +       unsigned int num_functions;

#ifdefed these

>  /**
> + * struct function_desc - generic function descriptor
> + * @name: name of the function
> + * @group_names: array of pin group names
> + * @num_group_names: number of pin group names
> + * @data: pin controller driver specific data
> + */
> +struct function_desc {
> +       const char *name;
> +       const char **group_names;
> +       int num_group_names;
> +       void *data;
> +};

And moved this into pinmux.h

Yours,
Linus Walleij