linux-kernel - Re: [PATCH] iio: adc: TI_AM335X_ADC should depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d8fc53e7-ee27-58f0-a117-190753079869@kernel.org>
Date:   Fri, 30 Dec 2016 16:39:20 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Mugunthan V N <mugunthanvnm@...com>,
        Peter Ujfalusi <peter.ujfalusi@...com>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: TI_AM335X_ADC should depend on HAS_DMA

On 14/12/16 12:30, Geert Uytterhoeven wrote:
> If NO_DMA=y:
> 
>     ERROR: "bad_dma_ops" [drivers/iio/adc/ti_am335x_adc.ko] undefined!
> 
> Add a dependency on HAS_DMA to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
Applied to the fixes-togreg-post-rc1 branch of iio.git (will unwind
this fun branch shortly now we are post rc1) and marked for stable
with an appropriate fixes tag added.

Thanks,

Jonathan
> ---
>  drivers/iio/adc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 38bc319904c4c299..9c8b558ba19ecb03 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -561,7 +561,7 @@ config TI_ADS8688
>  
>  config TI_AM335X_ADC
>  	tristate "TI's AM335X ADC driver"
> -	depends on MFD_TI_AM335X_TSCADC
> +	depends on MFD_TI_AM335X_TSCADC && HAS_DMA
>  	select IIO_BUFFER
>  	select IIO_KFIFO_BUF
>  	help
>