linux-kernel - Re: [PATCH] drivers: staging: iio: cdc: fix return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 30 Dec 2016 18:39:27 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Thomas Preisner <thomas.preisner+linux@....de>,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Cc:     linux-kernel@...cs.fau.de, milan.stephan+linux@....de,
        lars@...afoo.de, Michael.Hennerich@...log.com, knaack.h@....de,
        pmeerw@...erw.net, gregkh@...uxfoundation.org
Subject: Re: [PATCH] drivers: staging: iio: cdc: fix return value

On 23/12/16 18:51, Thomas Preisner wrote:
> At the end of function ad7150_write_event_config(), "return 0" seems
> improper. It may be better to return the value of ret.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188871
> 
> Reported-by: Pan Bian <bianpan2016@....com>
> Signed-off-by: Thomas Preisner <thomas.preisner+linux@....de>
> Signed-off-by: Milan Stephan <milan.stephan+linux@....de>
I already see a patch for this from Pan.

Jonathan
> ---
>  drivers/staging/iio/cdc/ad7150.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c
> index 6998c3d..04861eb 100644
> --- a/drivers/staging/iio/cdc/ad7150.c
> +++ b/drivers/staging/iio/cdc/ad7150.c
> @@ -274,7 +274,7 @@ static int ad7150_write_event_config(struct iio_dev *indio_dev,
>  error_ret:
>  	mutex_unlock(&chip->state_lock);
>  
> -	return 0;
> +	return ret;
>  }
>  
>  static int ad7150_read_event_value(struct iio_dev *indio_dev,
>