linux-kernel - Re: [PATCHv4 4/8] Fix braces not present on all arms of if else statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e9dafdc-1687-9392-5087-a2b846804b7d@kernel.org>
Date:   Fri, 30 Dec 2016 18:46:41 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Scott Matheina <scott@...heina.com>, linux-kernel@...r.kernel.org
Cc:     Hartmut Knaack <knaack.h@....de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCHv4 4/8] Fix braces not present on all arms of if else
 statement

On 25/12/16 19:56, Scott Matheina wrote:
> Adds braces to second arm of if else statement.
> 
> Signed-off-by: Scott Matheina <scott@...heina.com>
This patch is actually correct so applied to the togreg branch of iio.git.

Thanks,

Jonathan
> ---
>  drivers/staging/iio/addac/adt7316.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index 2b584a0..e78d302 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -661,8 +661,9 @@ static ssize_t adt7316_store_da_high_resolution(struct device *dev,
>  			chip->dac_bits = 12;
>  		else if (chip->id == ID_ADT7317 || chip->id == ID_ADT7517)
>  			chip->dac_bits = 10;
> -	} else
> +	} else {
>  		config3 = chip->config3 & (~ADT7316_DA_HIGH_RESOLUTION);
> +	}
>  
>  	ret = chip->bus.write(chip->bus.client, ADT7316_CONFIG3, config3);
>  	if (ret)
>