linux-kernel - Re: [PATCH] iio: mxs-lradc: fix error handling in mxs_lradc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <918653344.138229.1483128974311@email.1und1.de>
Date:   Fri, 30 Dec 2016 21:16:14 +0100 (CET)
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     Alexey Khoroshilov <khoroshilov@...ras.ru>,
        Jonathan Cameron <jic23@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     lee.jones@...aro.org, linux-kernel@...r.kernel.org,
        ldv-project@...uxtesting.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH] iio: mxs-lradc: fix error handling in mxs_lradc_probe()

> Jonathan Cameron <jic23@...nel.org> hat am 30. Dezember 2016 um 20:09 geschrieben:
> 
> 
> On 26/12/16 22:04, Stefan Wahren wrote:
> > 
> >> Alexey Khoroshilov <khoroshilov@...ras.ru> hat am 23. Dezember 2016 um 23:15 geschrieben:
> >>
> >>
> >> During transition to using devm_input_allocate_device()
> >> goto to resource deallocation block was replaced by return
> >> in case of error in iio_device_register().
> >> That is wrong since resources are left undeallocated.
> >>
> >> Found by Linux Driver Verification project (linuxtesting.org).
> >>
> >> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>
> >> Fixes: 962ed43a3eac ("iio: mxs-lradc: remove mxs_lradc_ts_unregister")
> > 
> > Acked-by: Stefan Wahren <stefan.wahren@...e.com>
> > 
> > But since Ksenija's patch series [1] (which doesn't have this issue) this patch is only relevant for stable.
> It's slightly doubtful as stable material as well unless it causes
> a crash. Obviously failing to clean up isn't good, but its not critical
> enough to justify the churn. 
> 
> Good find though.
> 
> Should you wish to post it to stable and let the stable maintainers make
> a decision feel free to do so.

No, i don't have any plans for that.

> 
> Jonathan
> > 
> > Thanks
> > 
> > [1] - http://marc.info/?l=linux-iio&m=148131774219426&w=2
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
>