linux-kernel - Re: [PATCH] This continues from this commit: 52f5684c8e1e ("kernel: use macros from compiler.h instead of __attribute_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1483145368.1955.6.camel@perches.com>
Date:   Fri, 30 Dec 2016 16:49:28 -0800
From:   Joe Perches <joe@...ches.com>
To:     gidisrael@...il.com, herbert@...dor.apana.org.au,
        davem@...emloft.net, nhorman@...driver.com,
        akpm@...ux-foundation.org, geert@...ux-m68k.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] This continues from this commit: 52f5684c8e1e ("kernel:
 use macros from compiler.h instead of __attribute__((...))")

On Sat, 2016-12-31 at 06:11 +0530, gidisrael@...il.com wrote:
> There is <linux/compiler.h> which provides macros for various gcc specific
> constructs. Eg: __weak for __attribute__((weak)). I've cleaned all
> instances of gcc specific attributes with the right macros for the crypto
> subsystem.
[]
> diff --git a/crypto/ablkcipher.c b/crypto/ablkcipher.c
[]
> @@ -394,7 +395,7 @@ static int crypto_ablkcipher_report(struct sk_buff *skb, struct crypto_alg *alg)
>  #endif
>  
>  static void crypto_ablkcipher_show(struct seq_file *m, struct crypto_alg *alg)
> -	__attribute__ ((unused));
> +	__always_unused;
>  static void crypto_ablkcipher_show(struct seq_file *m, struct crypto_alg *alg)
>  {
>  	struct ablkcipher_alg *ablkcipher = &alg->cra_ablkcipher;
> @@ -468,7 +469,7 @@ static int crypto_givcipher_report(struct sk_buff *skb, struct crypto_alg *alg)
>  #endif
>  
>  static void crypto_givcipher_show(struct seq_file *m, struct crypto_alg *alg)
> -	__attribute__ ((unused));
> +	__always_unused;
>  static void crypto_givcipher_show(struct seq_file *m, struct crypto_alg *alg)
>  {
>  	struct ablkcipher_alg *ablkcipher = &alg->cra_ablkcipher;

Perhaps it'd be better to remove the declaration/prototype
of crypto_ablkcipher_show and surround the definition of
crypto_ablkcipher_show with #ifdef CONFIG_PROC_FS / #endif

[]

> diff --git a/crypto/acompress.c b/crypto/acompress.c
[]
> @@ -50,7 +51,7 @@ static int crypto_acomp_report(struct sk_buff *skb, struct crypto_alg *alg)
>  #endif
>  
>  static void crypto_acomp_show(struct seq_file *m, struct crypto_alg *alg)
> -	__attribute__ ((unused));
> +	__always_unused;

likewise and for others too.