linux-kernel - Re: [RFC 2/4] x86/thread_info: kill TIF_ADDR32 in favour of ADDR_LIMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrWmfihj8BZZot7oEVkAhjrFtaKAoj77hq=mQrU2miwq+A@mail.gmail.com>
Date:   Fri, 30 Dec 2016 17:38:17 -0800
From:   Andy Lutomirski <luto@...capital.net>
To:     Dmitry Safonov <dsafonov@...tuozzo.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Dmitry Safonov <0x7f454c46@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        X86 ML <x86@...nel.org>
Subject: Re: [RFC 2/4] x86/thread_info: kill TIF_ADDR32 in favour of ADDR_LIMIT_32BIT

On Fri, Dec 30, 2016 at 7:56 AM, Dmitry Safonov <dsafonov@...tuozzo.com> wrote:
> This thread flag is completely x86-specific, consolidate it with
> ADDR_LIMIT_32BIT personality which is defined but not used on x86.
> It will free one of thread flags and consolidate personality with
> other arches.
> After this commit ADDR_LIMIT_32BIT is set by the kernel automatically
> in COMPAT_SET_PERSONALITY() for 32-bit ELF files and for 32-bit a.out.
> It's cleared in SET_PERSONALITY() for 64-bit ELFs.

I'm okay with this as a plain cleanup, but I'm not convinced that this
is really the right long-term solution.  See next email.