linux-kernel - Re: [PATCH] jump label: pass kbuild_cflags when checking for asm goto support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 1 Jan 2017 15:05:45 -0800
From:   David Lin <dtwlin@...gle.com>
To:     mmarek@...e.com, linux-kbuild@...r.kernel.org,
        linux-kernel@...r.kernel.org, jbaron@...mai.com,
        rostedt@...dmis.org, will.deacon@....com
Cc:     David Lin <dtwlin@...gle.com>
Subject: Re: [PATCH] jump label: pass kbuild_cflags when checking for asm goto support

+Cc: Steven Rostedt <rostedt@...dmis.org>
+Cc: Will Deacon <will.deacon@....com>

On Fri, Dec 9, 2016 at 4:46 PM, David Lin <dtwlin@...gle.com> wrote:
> Some versions of ARM GCC compiler such as Android toolchain throws in a
> '-fpic' flag by default. This causes the gcc-goto check script to fail
> although some config would have '-fno-pic' flag in the KBUILD_CFLAGS.
>
> This patch passes the KBUILD_CFLAGS to the check script so that the
> script does not rely on the default config from different compilers.
>
> Signed-off-by: David Lin <dtwlin@...gle.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 694111b..f667daa 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -790,7 +790,7 @@ KBUILD_CFLAGS   += $(call cc-option,-Werror=incompatible-pointer-types)
>  KBUILD_ARFLAGS := $(call ar-option,D)
>
>  # check for 'asm goto'
> -ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC)), y)
> +ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC) $(KBUILD_CFLAGS)), y)
>         KBUILD_CFLAGS += -DCC_HAVE_ASM_GOTO
>         KBUILD_AFLAGS += -DCC_HAVE_ASM_GOTO
>  endif
> --
> 2.10.2
>