linux-kernel - Re: [PATCH] mm: cma: print allocation failure reason and bitmap status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 2 Jan 2017 09:47:30 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Michal Nazarewicz <mina86@...a86.com>
Cc:     Jaewon Kim <jaewon31.kim@...sung.com>, gregkh@...uxfoundation.org,
        akpm@...ux-foundation.org, labbott@...hat.com,
        m.szyprowski@...sung.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, jaewon31.kim@...il.com
Subject: Re: [PATCH] mm: cma: print allocation failure reason and bitmap
 status

On Sun 01-01-17 22:59:40, Michal Nazarewicz wrote:
[...]
> Actually, Linux style is more like:
> 
> #ifdef CONFIG_CMA_DEBUG
> static void cma_debug_show_areas()
> {
> 	…
> }
> #else
> static inline void cma_debug_show_areas() { }
> #endif

yes, we usually do that when the function is externally visible. Inline
ifdef for static functions saves few lines. Not that it would matter
much though.
-- 
Michal Hocko
SUSE Labs