linux-kernel - Re: [PATCH] taint/module: Fix problems when out-of-kernel driver defines true or false

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170102105142.GE14894@pathway.suse.cz>
Date:   Mon, 2 Jan 2017 11:51:43 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     Larry Finger <Larry.Finger@...inger.net>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, Jessica Yu <jeyu@...hat.com>,
        Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [PATCH] taint/module: Fix problems when out-of-kernel driver
 defines true or false

On Sun 2017-01-01 20:25:25, Larry Finger wrote:
> Commit 7fd8329ba502 ("taint/module: Clean up global and module taint
> flags handling") used the key words true and false as character members
> of a new struct. These names cause problems when out-of-kernel modules
> such as VirtualBox include their own definitions of true and false.
> 
> Fixes: 7fd8329ba502 ("taint/module: Clean up global and module taint flags handling")
> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
> Cc: Petr Mladek <pmladek@...e.com>
> Cc: Jessica Yu <jeyu@...hat.com>
> Cc: Rusty Russell <rusty@...tcorp.com.au>

I like this variant a bit more than the tainted/untainted one.

Reviewed-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr