linux-kernel - Re: [PATCH v6 7/9] i2c: i2c-mux-simple: new driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49bbe0f9-8cf7-c932-265e-ebab39bc2a1e@axentia.se>
Date:   Mon, 2 Jan 2017 16:30:02 +0100
From:   Peter Rosin <peda@...ntia.se>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Wolfram Sang <wsa@...-dreams.de>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Jonathan Corbet <corbet@....net>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-i2c@...r.kernel.org, devicetree <devicetree@...r.kernel.org>,
        linux-iio@...r.kernel.org,
        Linux Documentation List <linux-doc@...r.kernel.org>
Subject: Re: [PATCH v6 7/9] i2c: i2c-mux-simple: new driver

On 2017-01-01 16:38, Andy Shevchenko wrote:
> On Wed, Nov 30, 2016 at 10:17 AM, Peter Rosin <peda@...ntia.se> wrote:
>> This is a generic simple i2c mux that uses the generic multiplexer
>> subsystem to do the muxing.
> 
>> +static const struct of_device_id i2c_mux_of_match[] = {
>> +       { .compatible = "i2c-mux-simple,parent-locked",
>> +         .data = (void *)0, },
>> +       { .compatible = "i2c-mux-simple,mux-locked",
>> +         .data = (void *)1, },
>> +       {},
>> +};
> 
> Perhaps
> 
> #define I2C_MUX_LOCKED_PARENT  0
> #define I2C_MUX_LOCKED         1

I2C_MUX_LOCKED is already "taken" in include/linux/i2c-mux.h but I'll
use SIMPLE_PARENT_LOCKED and SIMPLE_MUX_LOCKED instead.

Cheers,
peda