linux-kernel - Re: [PATCH] hwmon: (lm90) fix temp1_max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a894a5a1-f24f-6d32-327e-d124c485f446@roeck-us.net>
Date:   Mon, 2 Jan 2017 10:15:44 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Michael Walle <michael@...le.cc>, linux-hwmon@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (lm90) fix temp1_max_alarm attribute

On 01/02/2017 08:53 AM, Michael Walle wrote:
> Since commit commit eb1c8f4325d5 ("hwmon: (lm90) Convert to use new hwmon
> registration API") the temp1_max_alarm and temp1_crit_alarm attributes are
> mapped to the same alarm bit. Fix the typo.
>
> Fixes: eb1c8f4325d5 ("hwmon: (lm90) Convert to use new hwmon registration API")
> Signed-off-by: Micehael Walle <michael@...le.cc>

Good catch. Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/lm90.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c
> index 322ed92..841f242 100644
> --- a/drivers/hwmon/lm90.c
> +++ b/drivers/hwmon/lm90.c
> @@ -1036,7 +1036,7 @@ static const u8 lm90_temp_emerg_index[3] = {
>  };
>
>  static const u8 lm90_min_alarm_bits[3] = { 5, 3, 11 };
> -static const u8 lm90_max_alarm_bits[3] = { 0, 4, 12 };
> +static const u8 lm90_max_alarm_bits[3] = { 6, 4, 12 };
>  static const u8 lm90_crit_alarm_bits[3] = { 0, 1, 9 };
>  static const u8 lm90_emergency_alarm_bits[3] = { 15, 13, 14 };
>  static const u8 lm90_fault_bits[3] = { 0, 2, 10 };
>