linux-kernel - Re: [PATCH v2 4/6] staging: fbtft: propagate error code from kstrto*()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Jan 2017 02:19:40 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     kbuild-all@...org,
        Noralf Trønnes <noralf@...nnes.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org,
        Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        linux-kernel@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v2 4/6] staging: fbtft: propagate error code from
 kstrto*()

Hi Andy,

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v4.10-rc2 next-20161224]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/fbtft-make-it-work-with-DMA-enabled-SPI/20170102-201151
config: openrisc-allyesconfig (attached as .config)
compiler: or32-linux-gcc (GCC) 4.5.1-or32-1.0rc1
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=openrisc 

All warnings (new ones prefixed by >>):

   drivers/staging/fbtft/fbtft-sysfs.c: In function 'get_next_ulong':
>> drivers/staging/fbtft/fbtft-sysfs.c:7:6: warning: unused variable 'ret'

vim +/ret +7 drivers/staging/fbtft/fbtft-sysfs.c

c296d5f9 Thomas Petazzoni 2014-12-31   1  #include "fbtft.h"
f3e5df43 Peter Poklop     2015-03-18   2  #include "internal.h"
c296d5f9 Thomas Petazzoni 2014-12-31   3  
c296d5f9 Thomas Petazzoni 2014-12-31   4  static int get_next_ulong(char **str_p, unsigned long *val, char *sep, int base)
c296d5f9 Thomas Petazzoni 2014-12-31   5  {
c296d5f9 Thomas Petazzoni 2014-12-31   6  	char *p_val;
c296d5f9 Thomas Petazzoni 2014-12-31  @7  	int ret;
c296d5f9 Thomas Petazzoni 2014-12-31   8  
c296d5f9 Thomas Petazzoni 2014-12-31   9  	if (!str_p || !(*str_p))
c296d5f9 Thomas Petazzoni 2014-12-31  10  		return -EINVAL;
c296d5f9 Thomas Petazzoni 2014-12-31  11  
c296d5f9 Thomas Petazzoni 2014-12-31  12  	p_val = strsep(str_p, sep);
c296d5f9 Thomas Petazzoni 2014-12-31  13  
c296d5f9 Thomas Petazzoni 2014-12-31  14  	if (!p_val)
c296d5f9 Thomas Petazzoni 2014-12-31  15  		return -EINVAL;

:::::: The code at line 7 was first introduced by commit
:::::: c296d5f9957c03994a699d6739c27d4581a9f6c7 staging: fbtft: core support

:::::: TO: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
:::::: CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (40203 bytes)