linux-kernel - Re: [PATCH] dmaengine: omap-dma: Fix dynamic lch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170102191328.pssv24pzxhguyeby@raspberrypi-2.musicnaut.iki.fi>
Date:   Mon, 2 Jan 2017 21:13:28 +0200
From:   Aaro Koskinen <aaro.koskinen@....fi>
To:     Peter Ujfalusi <peter.ujfalusi@...com>
Cc:     vinod.koul@...el.com, dan.j.williams@...el.com,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org, tony@...mide.com,
        stable@...r.kernel.org
Subject: Re: [PATCH] dmaengine: omap-dma: Fix dynamic lch_map alocation

Hi,

On Mon, Jan 02, 2017 at 12:07:37PM +0200, Peter Ujfalusi wrote:
> The original patch did not done what it was supposed to be doing and even
> worst it broke legacy boot (OMAP1).
> 
> The lch_map size should be the number of available logical channels in sDMA
> and the od->dma_requests should store the number of available DMA request
> lines usable in sDMA.
> 
> In legacy mode we do not have a way to get the DMA request count, in that
> case we use OMAP_SDMA_REQUESTS (127), despite the fact that OMAP1510 have
> only 31 DMA request line.
> 
> Fixes: 2d1a9a946fae ("dmaengine: omap-dma: Dynamically allocate memory for lch_map")
> Reported-by: Aaro Koskinen <aaro.koskinen@....fi>
> Cc: stable@...r.kernel.org   # v4.9
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>

Tested-by: Aaro Koskinen <aaro.koskinen@....fi>

Thanks,

A.