linux-kernel - Re: [PATCH] auxdisplay: fix new ht16k33 build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170102084524.3d603fd3@erd979>
Date:   Mon, 2 Jan 2017 08:45:24 +0100
From:   Robin van der Gracht <robin@...tonic.nl>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Fengguang Wu <fengguang.wu@...el.com>,
        Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>
Subject: Re: [PATCH] auxdisplay: fix new ht16k33 build errors

On Mon, 26 Dec 2016 09:58:34 -0800
Randy Dunlap <rdunlap@...radead.org> wrote:

> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Fix build errors caused by selecting incorrect kconfig symbols.
> 
> drivers/built-in.o:(.data+0x19cec): undefined reference to `sys_fillrect'
> drivers/built-in.o:(.data+0x19cf0): undefined reference to `sys_copyarea'
> drivers/built-in.o:(.data+0x19cf4): undefined reference to `sys_imageblit'
> 
> Fixes: 31114fa95bdb (auxdisplay: ht16k33: select framebuffer helper modules)
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc:	Robin van der Gracht <robin@...tonic.nl>
> Cc:	Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>
> Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> ---
>  drivers/auxdisplay/Kconfig |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> --- lnx-410-rc1.orig/drivers/auxdisplay/Kconfig
> +++ lnx-410-rc1/drivers/auxdisplay/Kconfig
> @@ -132,9 +132,9 @@ config HT16K33
>  	tristate "Holtek Ht16K33 LED controller with keyscan"
>  	depends on FB && OF && I2C && INPUT
>  	select FB_SYS_FOPS
> -	select FB_CFB_FILLRECT
> -	select FB_CFB_COPYAREA
> -	select FB_CFB_IMAGEBLIT
> +	select FB_SYS_FILLRECT
> +	select FB_SYS_COPYAREA
> +	select FB_SYS_IMAGEBLIT
>  	select INPUT_MATRIXKMAP
>  	select FB_BACKLIGHT
>  	help

Acked-by: Robin van der Gracht <robin@...tonic.nl>