linux-kernel - Re: Nokia N900 sound driver and ECI GPIOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 2 Jan 2017 10:23:23 +0200
From:   Peter Ujfalusi <peter.ujfalusi@...com>
To:     Pali Rohár <pali.rohar@...il.com>,
        Jarkko Nikula <jarkko.nikula@...mer.com>,
        Tony Lindgren <tony@...mide.com>,
        Eduardo Valentin <edubezval@...il.com>
CC:     Lars-Peter Clausen <lars@...afoo.de>,
        Aaro Koskinen <aaro.koskinen@....fi>,
        Nishanth Menon <nm@...com>, Sebastian Reichel <sre@...nel.org>,
        Pavel Machek <pavel@....cz>,
        Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
        joerg Reisenweber <joerg@...nmoko.org>,
        <linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: Nokia N900 sound driver and ECI GPIOs

Hi,

On 01/01/2017 09:54 PM, Pali Rohár wrote:
> Hi!
> 
> I'm looking at original Maemo N900 2.6.28 sound driver and GPIOs which
> controls A/V jack detection.
> 
> For reference source code of that driver can be found e.g. at alsa-devel
> ML [1] [2] or in my linux-n900 git tree, branch v2.6.28-nokia [3].
> 
> In that sound/soc/omap/rx51.c code is function rx51_set_eci_switches()
> which configures 2 gpios: RX51_ECI_SWITCH_1_GPIO = gpio 178 and
> RX51_ECI_SWITCH_2_GPIO = gpio 182 based on "eci mode" input parameter.
> 
> But in mainline kernel code [4] [5] there is no information about gpio 178
> (as RX51_ECI_SWITCH_1_GPIO) and gpio 182 is called as just "eci-switch".
> More interesting part is that "eci-switch" gpio is not used in whole
> mainline code. It is just referenced in Nokia N900 DTS [4]. Looks like
> sound driver in mainline kernel is incomplete.
> 
> Jarkko, you are listed as original author of that driver. Do you (or
> anybody else) remember what that rx51_set_eci_switches() function is
> doing? And what gpio 178 controls? I was even not able to find gpio 178
> in RX-51 Schematics [6].

GPIO_182 is to select where to route the MIC line from the jack for the
ECI core to handle (when the TVOUT is disabled). I have no idea what the
gpio_178 should have been used for. It might be only needed for early
protos but not in production devices?

> And do you know something about Nokia ECI headsets supports for Nokia
> N900. Looks like there is already some kernel code but support for ECI
> bus or multibuttons headset is missing.

Not sure if n900 had full support for ECI, afaik n9 did supported it.
The ECI input driver was sent upstream, but can not recall the reason
why it is not in mainline:

https://patchwork.kernel.org/patch/450811/

> 
> [1] - http://mailman.alsa-project.org/pipermail/alsa-devel/2009-October/022033.html
> 
> [2] - http://mailman.alsa-project.org/pipermail/alsa-devel/2009-October/022039.html
> 
> [3] - https://github.com/pali/linux-n900/blob/v2.6.28-nokia/sound/soc/omap/rx51.c
> 
> [4] - https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/omap3-n900.dts#n128
> 
> [5] - https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/soc/omap/rx51.c
> 
> [6] - https://wiki.maemo.org/N900_Hardware_Schematic
> 

-- 
Péter